svn commit: r351471 - in head/sys: kern sys

[Ian Lepore]

On Sat, 2019-08-31 at 00:03 +0200, Mateusz Guzik wrote:
> On 8/25/19, Oliver Pinter <oliver.pinter at hardenedbsd.org> wrote:
> > On Sunday, August 25, 2019, Mateusz Guzik <mjg at freebsd.org> wrote:
> > 
> > > Author: mjg
> > > Date: Sun Aug 25 05:11:43 2019
> > > New Revision: 351471
> > > URL: https://svnweb.freebsd.org/changeset/base/351471
> > > 
> > > Log:
> > >   vfs: add vholdnz (for already held vnodes)
> > 
> > 
> > Why?
> > 
> > (Yes, is can read the real reason in phabricator, but the
> > phabricator
> > didn't considered a persistent information in relation to commit
> > message.
> > Review helper tool just comes and goes as time goes forward, but
> > commit
> > messages survives the repo conversions to other VCS...)
> > 
> > And once you have taken the time to write a correct description in
> > phabricator, it would be really really nice and helpful if you
> > would copy
> > them into commit message.
> > 
> 
> I think it's a fair point that if I included this info in the review
> it
> should make it's way into the commit message.
> 

When I open a new phab review, I specifically write the one-line
summary and text that follows with the idea that I'm going to cut and
paste that exact text as the commit message (mostly because it's easier
to just write all that stuff once).  If there are things I want to say
there that don't make sense for the commit I typically add them as a
separate comment right after I open the initial review.

-- Ian