svn commit: r351622 - head/sys/kern

Mateusz Guzik mjguzik at gmail.com
Fri Aug 30 22:00:27 UTC 2019


On 8/30/19, Konstantin Belousov <kostikbel at gmail.com> wrote:
> On Fri, Aug 30, 2019 at 12:45:54AM +0000, Mateusz Guzik wrote:
>> +	VNASSERT(vp->v_holdcnt > 0 && vp->v_usecount > 0, vp,
> A more precise assert condition would also include
> 	vp->v_holdcont >= vp->v_usecount
>

I agree, but that would be problematic to test for due to other threads
playing with these counters.

Note this commit was just diff reduction for "usecount implies holdcnt"
( https://reviews.freebsd.org/D21471 ) after which the stronger assertion
would not hold.

-- 
Mateusz Guzik <mjguzik gmail.com>


More information about the svn-src-head mailing list