svn commit: r351456 - head/sys/amd64/amd64

Conrad Meyer cem at freebsd.org
Sat Aug 24 18:48:07 UTC 2019


On Sat, Aug 24, 2019 at 9:15 AM Konstantin Belousov <kostikbel at gmail.com> wrote:
>
> On Sat, Aug 24, 2019 at 08:49:42AM -0700, Conrad Meyer wrote:
> > Hi Konstantin,
> >
> > What is the motivation for this change?  The commit message doesn't
> > really describe why it was done.
>
> Really it does. There is no point to request allocations for e.g.
> doublefault stack to be at the local domain, because this stack is only
> used once.  Doublefault is definitely a machine halt situation, it does
> not matter if it generates inter-socket traffic to handle.
>
> Same for boot stacks, and for mce.
>
> The change avoids unnecessary constraints.

Sure, but what is the harm of the unnecessary constraints?  Does this
change fix an actual bug, or is it just a stylistic preference to
avoid domain-specific allocations for infrequently used objects?

Thanks,
Conrad


More information about the svn-src-head mailing list