svn commit: r351406 - head/sys/dev/nvme

John Baldwin jhb at FreeBSD.org
Thu Aug 22 21:27:25 UTC 2019


On 8/22/19 2:12 PM, Warner Losh wrote:
> Author: imp
> Date: Thu Aug 22 21:12:51 2019
> New Revision: 351406
> URL: https://svnweb.freebsd.org/changeset/base/351406
> 
> Log:
>   We need to define version 1 of nvme, not nvme_foo. Otherwise nvd won't
>   load and people who pull in nvme/nvd from modules can't load nvd.ko
>   since it depends on nvme, not nvme_foo. The duplicate doesn't matter
>   since kldxref properly handles that case.

I would perhaps have put the MODULE_VERSION for nvme and its dependency
on cam into nvme.c instead of duplicating it.  I think that is more consistent
with what we have done elsewhere in the tree.

-- 
John Baldwin


More information about the svn-src-head mailing list