svn commit: r351244 - head/sys/dev/usb/net

Stephen J. Kiernan stevek at FreeBSD.org
Tue Aug 20 01:06:44 UTC 2019


Author: stevek
Date: Tue Aug 20 01:06:43 2019
New Revision: 351244
URL: https://svnweb.freebsd.org/changeset/base/351244

Log:
  usb_ethernet.h includes a number of mii headers, but only does so in
  order to have struct mii_data available. However, it only really needs
  a forward declaration of struct mii_data for use in pointer form for
  the return type of a function prototype.
  
  Custom kernel configuration that have usb and fdt enabled, but no miibus,
  end up with compilation failures because miibus_if.h will not get
  generated.
  
  Due to the above, the following changes have been made to usb_ethernet.h:
   * remove the inclusion of mii headers
   * forward-declare struct mii_data
   * include net/ifq.h to satify the need for complete struct ifqueue
  
  Reviewed by:	ian
  Obtained from:	Juniper Networks, Inc.
  Differential Revision:	https://reviews.freebsd.org/D21293

Modified:
  head/sys/dev/usb/net/usb_ethernet.h

Modified: head/sys/dev/usb/net/usb_ethernet.h
==============================================================================
--- head/sys/dev/usb/net/usb_ethernet.h	Tue Aug 20 00:50:17 2019	(r351243)
+++ head/sys/dev/usb/net/usb_ethernet.h	Tue Aug 20 01:06:43 2019	(r351244)
@@ -45,14 +45,11 @@
 #include <net/if_dl.h>
 #include <net/if_media.h>
 #include <net/if_types.h>
+#include <net/ifq.h>
 #include <net/bpf.h>
 #include <net/ethernet.h>
 
-#include "miibus_if.h"
-
-#include <dev/mii/mii.h>
-#include <dev/mii/miivar.h>
-
+struct mii_data;
 struct usb_ether;
 struct usb_device_request;
 


More information about the svn-src-head mailing list