svn commit: r350777 - head/sys/kern

Rick Macklem rmacklem at FreeBSD.org
Thu Aug 8 20:07:39 UTC 2019


Author: rmacklem
Date: Thu Aug  8 20:07:38 2019
New Revision: 350777
URL: https://svnweb.freebsd.org/changeset/base/350777

Log:
  Remove some harmless cruft from vn_generic_copy_file_range().
  
  An earlier version of the patch had code that set "error" between
  line#s 2797-2799. When that code was moved, the second check for "error != 0"
  could never be true and the check became harmless cruft.
  This patch removes the cruft, mainly to make Coverity happy.
  
  Reported by:	asomers, cem

Modified:
  head/sys/kern/vfs_vnops.c

Modified: head/sys/kern/vfs_vnops.c
==============================================================================
--- head/sys/kern/vfs_vnops.c	Thu Aug  8 19:53:07 2019	(r350776)
+++ head/sys/kern/vfs_vnops.c	Thu Aug  8 20:07:38 2019	(r350777)
@@ -2798,8 +2798,6 @@ vn_generic_copy_file_range(struct vnode *invp, off_t *
 	if (VOP_PATHCONF(invp, _PC_MIN_HOLE_SIZE, &holein) != 0)
 		holein = 0;
 	VOP_UNLOCK(invp, 0);
-	if (error != 0)
-		goto out;
 
 	mp = NULL;
 	error = vn_start_write(outvp, &mp, V_WAIT);


More information about the svn-src-head mailing list