svn commit: r346390 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

[Enji Cooper]

> On Apr 19, 2019, at 08:44, Alexander Motin <mav at freebsd.org> wrote:
> 
> Author: mav
> Date: Fri Apr 19 15:44:45 2019
> New Revision: 346390
> URL: https://svnweb.freebsd.org/changeset/base/346390
> 
> Log:
>  Change the way FreeBSD GID inheritance is hacked.
> 
>  I believe previous ifdef caused NULL dereference in later zfs_log_create()
>  on attempt to create file inside directory belonging to ephemeral group
>  created on illumos, trying to write to log information about GID domain
>  of the newly created file, inheriting the ephemeral GID.
> 
>  This patch reuses original illumos SGID code with exception that due to
>  lack of ID mapping code on FreeBSD ephemeral GID will turn into GID_NOBODY
>  by another ifdef inside zfs_fuid_map_id().

Hi mav@!
    I was wondering, does this break ACL mappings with sticky bits for the group ID (or was it broken to begin with)? If the latter, does it make sense to file a bug/add a TODO comment?
Thank you!
-Enji