svn commit: r345900 - head/sbin/fsck_msdosfs

[Rodney W. Grimes]

> On Fri, Apr 5, 2019 at 6:49 AM Ed Maste <emaste at freebsd.org> wrote:
> >
> > On Fri, 5 Apr 2019 at 00:49, Rodney W. Grimes <freebsd at gndrsh.dnsmgr.net> wrote:
> > >
> >
> > > > +static const u_char dot_name[] = {
> > > > +     '.', ' ',' ',' ',' ',' ',' ',' ',' ',' ',' ' };
> > > > +static const u_char dotdot_name[] = {
> > > > +     '.', '.',' ',' ',' ',' ',' ',' ',' ',' ',' ' };
> > > > +
> >
> > They are all either '.' or ' ', the commas are just list separators.
> > IMO spaces after the commas would make it slightly easier to see.
> 
> Would it make sense to just use the normal string syntax for char
> array assignment?
> 
> static const u_char dot_name[11] = ".          ";
> static const u_char dotdot_name[11] = "..         ";
> 
> Seems more clear to me.

To try and end this thread, I already stated it was in review,
let me get a pointer to it, if you have comments please post
them there:
https://reviews.freebsd.org/D19829

-- 
Rod Grimes                                                 rgrimes at freebsd.org