svn commit: r339936 - head/sys/amd64/vmm/amd

Shawn Webb shawn.webb at hardenedbsd.org
Wed Oct 31 14:07:17 UTC 2018


On Wed, Oct 31, 2018 at 01:27:44AM +0000, Marcelo Araujo wrote:
> Author: araujo
> Date: Wed Oct 31 01:27:44 2018
> New Revision: 339936
> URL: https://svnweb.freebsd.org/changeset/base/339936
> 
> Log:
>   Merge cases with upper block.
>   This is a cosmetic change only to simplify code.
>   
>   Reported by:	anish
>   Sponsored by:	iXsystems Inc.
> 
> Modified:
>   head/sys/amd64/vmm/amd/svm_msr.c
> 
> Modified: head/sys/amd64/vmm/amd/svm_msr.c
> ==============================================================================
> --- head/sys/amd64/vmm/amd/svm_msr.c	Tue Oct 30 23:09:04 2018	(r339935)
> +++ head/sys/amd64/vmm/amd/svm_msr.c	Wed Oct 31 01:27:44 2018	(r339936)
> @@ -122,11 +122,7 @@ svm_rdmsr(struct svm_softc *sc, int vcpu, u_int num, u
>  	case MSR_MTRR16kBase ... MSR_MTRR16kBase + 1:
>  	case MSR_MTRR64kBase:
>  	case MSR_SYSCFG:
> -		*result = 0;
> -		break;
>  	case MSR_AMDK8_IPM:
> -		*result = 0;
> -		break;
>  	case MSR_EXTFEATURES:
>  		*result = 0;
>  		break;

Does this need a /* FALLTHROUGH */ comment to appease the Coverity
Gods?

Thanks,

-- 
Shawn Webb
Cofounder and Security Engineer
HardenedBSD

Tor-ified Signal:    +1 443-546-8752
Tor+XMPP+OTR:        lattera at is.a.hacker.sx
GPG Key ID:          0x6A84658F52456EEE
GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89  3D9E 6A84 658F 5245 6EEE
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20181031/ea83394d/attachment.sig>


More information about the svn-src-head mailing list