svn commit: r340722 - head/lib/libbe

[Rodney W. Grimes]

> On Wed, Nov 21, 2018 at 10:19 AM Rodney W. Grimes
> <freebsd at pdx.rh.cn85.dnsmgr.net> wrote:
> >
> > > Author: 0mp (ports committer)
> > > Date: Wed Nov 21 11:22:44 2018
> > > New Revision: 340722
> > > URL: https://svnweb.freebsd.org/changeset/base/340722
> > >
> > > Log:
> > >   libbe(3): Put each error value in separate line.
> > >
> > >   As requested by a TODO in the source code.
> > >
> > >   Reviewed by:        bcr
> > >   Approved by:        krion (mentor, implicit), mat (mentor, implicit)
> > >   Differential Revision:      https://reviews.freebsd.org/D18063
> >
> > Who with a src bit approved the commit to src?
> >
> 
> I do want to clarify- bcr approved it in the review (explicitly with
> "... hereby approved!") -- are you mainly pointing out that he failed
> to annotate this properly in the commit, or is doc bit approval for a
> commit to a manpage in src insufficient?

That is defanitly a bit of a grey area, from reading and re-reading
the commit bit page it is clear that a doc committer can commit
to src documentation, it is not clear if they can approve a commit
by someone else to the src tree, it does say
	""Approved by" from a non-mentored committer
	 with the appropriate bit"

It probably would be fine to have said Approved by: bcr.

I still question what a out of scope commit that is
approved by: (mentor, implicit).  I am not even sure
what that means in this context.  Have his mentors
said he can commit anything anyplace without them
seeing it?  If so then release the mentor/mentee bit
would be more appropriate?

> 
> As an aside, happy to approve any changes to these manpages as the
> current bectl/libbe maintainer for anyone that wants to improve them.
> =)

That defanitly would of been a cleaner path.

> 
> Thanks,
> 
> Kyle Evans
> 

-- 
Rod Grimes                                                 rgrimes at freebsd.org