svn commit: r340055 - in head: share/man/man9 sys/cddl/contrib/opensolaris/uts/common/fs/zfs sys/fs/ext2fs sys/fs/fuse sys/fs/nandfs sys/fs/nfs sys/fs/nfsclient sys/fs/tmpfs sys/kern sys/sys sys/uf...
Brooks Davis
brooks at freebsd.org
Fri Nov 2 16:19:00 UTC 2018
On Fri, Nov 02, 2018 at 04:49:00PM +0200, Andriy Gapon wrote:
> On 02/11/2018 16:42, Brooks Davis wrote:
> > Author: brooks
> > Date: Fri Nov 2 14:42:36 2018
> > New Revision: 340055
> > URL: https://svnweb.freebsd.org/changeset/base/340055
> >
> > Log:
> > Make vop_symlink take a const target path.
> >
> > This will enable callers to take const paths as part of syscall
> > decleration improvements.
> >
> > Where doing so is easy and non-distruptive carry the const through
> > implementations. In UFS the value is passed to an interface that must
> > take non-const values. In ZFS, const poisoning would touch code shared
> > with upstream and it's not worth adding diffs.
>
> zfs_vnops.c is already sufficiently different from upstream (because of quite
> different VFS models), so a small difference in zfs_symlink's signature would
> not be too bad.
Good to know. When I hit modifying three files I stopped. I'll
keep this in the back of my mind as a possible improvement.
Thanks,
Brooks
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 455 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20181102/9d1296a2/attachment.sig>
More information about the svn-src-head
mailing list