svn commit: r334361 - head/usr.sbin/pmc

[Dimitry Andric]

On 30 May 2018, at 11:24, Konstantin Belousov <kostikbel at gmail.com> wrote:
> 
> On Wed, May 30, 2018 at 12:06:17AM +0000, Matt Macy wrote:
>> Author: mmacy
>> Date: Wed May 30 00:06:17 2018
>> New Revision: 334361
>> URL: https://svnweb.freebsd.org/changeset/base/334361
>> 
>> Log:
>>  pmc: don't break build with format issues
>> 
>> Modified:
>>  head/usr.sbin/pmc/Makefile
>> 
>> Modified: head/usr.sbin/pmc/Makefile
>> ==============================================================================
>> --- head/usr.sbin/pmc/Makefile	Tue May 29 23:08:33 2018	(r334360)
>> +++ head/usr.sbin/pmc/Makefile	Wed May 30 00:06:17 2018	(r334361)
>> @@ -9,4 +9,5 @@ LIBADD=	kvm pmc m ncursesw pmcstat elf
>> 
>> SRCS=	pmc.c pmc_util.c cmd_pmc_stat.c
>> 
>> +CWARNFLAGS.cmd_pmc_stat.c=	-Wno-format
>> .include <bsd.prog.mk>
> So this builds knownly broken binary instead of stopping.
> 
> If I understand your troubles right, the usual solution for them is
> 	printf("%jx", (uintmax_t)trouble);
> used in many places around the kernel, less so in userspace.

Yes, or include <inttypes.h> and use the PRIu64 macro, even though Bruce
hates it. :)

-Dimitry

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 223 bytes
Desc: Message signed with OpenPGP
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20180530/0873a15c/attachment.sig>