svn commit: r333407 - head/share/mk

[Ian Lepore]

On Fri, 2018-05-25 at 14:10 -0700, Bryan Drewery wrote:
> On 5/9/2018 6:44 AM, Brad Davis wrote:
> > 
> > Author: brd
> > Date: Wed May  9 13:44:54 2018
> > New Revision: 333407
> > URL: https://svnweb.freebsd.org/changeset/base/333407
> > 
> > Log:
> >   Enable directory creation with FILESDIR.
> >   
> >   This is part of packaging base work.
> >   
> >   Reviewed by:	will
> >   Approved by:	bapt (mentor), allanjude (mentor)
> >   Differential Revision:	https://reviews.freebsd.org/D15130
> > 
> Please update share/mk/bsd.README too.
> 
> I know I haven't been very responsive but it's partly because I'm still
> fundamentally against this feature. It's adding a mechanism to replace
> mtree without considering the whole picture and only binding it to FILES
> rather than a bsd.dirs.mk; It doesn't actually satisfy replacing mtree
> files since it only works if there is a FILESGROUP used (FILES must be
> non-empty). So what's the point? My major concern is added confusion.
> The creation of directories for installing is a pain point at work for
> developers but I don't think this is enough. I liked the idea of
> `install "-D"` but I know it's not efficient and had some implementation
> issues.

I welcome this work. If it's not complete/perfect, we can iterate
towards that, but mtree is not a good solution for out-of-tree builds
that use the build machinery in /usr/share/mk. The lack of a solution
other than mtree has led to half a dozen different hacks scattered
around the makefiles in our application repo, and it's about time this
hole in the build system gets plugged.

-- Ian