svn commit: r334128 - in head: . lib/libpmcstat lib/libpmcstat/pmu-events lib/libpmcstat/pmu-events/arch lib/libpmcstat/pmu-events/arch/arm64 lib/libpmcstat/pmu-events/arch/arm64/arm lib/libpmcstat...

[Bryan Drewery]

On 5/23/2018 9:30 PM, Matt Macy wrote:
> Author: mmacy
> Date: Thu May 24 04:30:06 2018
> New Revision: 334128
> URL: https://svnweb.freebsd.org/changeset/base/334128
> 
> Log:
>   libpmcstat: compile in events based on json description
> 
> Added:
>   head/lib/libpmcstat/libpmcstat_pmu_util.c   (contents, props changed)
>   head/lib/libpmcstat/pmu-events/
>   head/lib/libpmcstat/pmu-events/Makefile   (contents, props changed)

...

> # cat lib/libpmcstat/pmu-events/Makefile
> # $FreeBSD$
> 
> PROG=jevents
> SRCS=jevents.c jsmn.c json.c
> CFLAGS+= -Wno-cast-qual
> .PATH: ${.CURDIR}
> build-tools: jevents
> MAN=
> .include <bsd.prog.mk>

Several things wrong here and in lib/libpmcstat/Makefile

1. Newlines? Existing style from other Makefiles? style.Makefile(5)
2. .PATH implicitly has .CURDIR in it already.
3. Need special META_MODE handling for the build-tools target. I don't
necessarily expect people to get this right but every other use of
build-tools in the tree has a pattern that isn't used here.
4. You used HOST_OBJTOP in lib/libpmcstat/Makefile to refer to jevents
for some reason when nothing else does. This is really just the
META_MODE pattern being wrong.

I'm fixing all of this.

-- 
Regards,
Bryan Drewery

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20180525/57012e78/attachment.sig>