svn commit: r334129 - head/sys/amd64/conf

Rodney W. Grimes freebsd at pdx.rh.CN85.dnsmgr.net
Thu May 24 14:24:02 UTC 2018


> On 24 May 2018 at 01:36, Matthew Macy <mmacy at freebsd.org> wrote:
> > On Wed, May 23, 2018 at 10:32 PM, Ravi Pokala <rpokala at freebsd.org> wrote:
> >>>
> >>> Author: mmacy
> >>> Date: Thu May 24 04:31:53 2018
> >>> New Revision: 334129
> >>> URL: https://svnweb.freebsd.org/changeset/base/334129
> >>>
> >>> Log:
> >>>   take NUMA out
> >>> ...
> >> Why?
> >
> >
> > I ^C'd the prior commit too late.
> 
> For cases like this the commit message should include something like
> "It was accidentally committed in r334128."

Would it not make some sense to revert and recommit when these happen,
especially if there is an intenent to MFC, otherwise one has to be
sure to merge both parts to end up with a corrected commit to stable/

We seem to be afraid of revert, recommit correcting cycles,
and in the long run that may be causing us some problems.

Just a though.

-- 
Rod Grimes                                                 rgrimes at freebsd.org


More information about the svn-src-head mailing list