svn commit: r332730 - in head/sys: amd64/amd64 i386/i386 powerpc/powerpc

Andriy Gapon avg at FreeBSD.org
Mon May 14 19:16:07 UTC 2018


On 05/05/2018 01:55, John Baldwin wrote:
> On Wednesday, April 18, 2018 03:44:54 PM Andriy Gapon wrote:
>> Author: avg
>> Date: Wed Apr 18 15:44:54 2018
>> New Revision: 332730
>> URL: https://svnweb.freebsd.org/changeset/base/332730
>>
>> Log:
>>   don't check for kdb reentry in trap_fatal(), it's impossible
>>   
>>   trap() checks for it earlier and calls kdb_reentry().
> 
> I just noticed today that there are several other kdb_trap() checks in
> other architectures that need this fix and the KDB_WHY_TRAP change.  Just
> grep for debugger_on_panic under sys.  For example:
> 
> arm/arm/trap-v4.c:      if (debugger_on_panic || kdb_active)
> arm/arm/trap-v6.c:      if (debugger_on_panic || kdb_active)
> arm64/arm64/trap.c:                     if (debugger_on_panic || kdb_active)
> mips/mips/trap.c:               if (debugger_on_panic || kdb_active) {

This list seems to be exhaustive.
Please see https://reviews.freebsd.org/D15431
Thanks!

-- 
Andriy Gapon


More information about the svn-src-head mailing list