svn commit: r333393 - head/sys/contrib/ipfilter/netinet

[Warner Losh]

On Wed, May 9, 2018 at 10:52 AM, John Baldwin <jhb at freebsd.org> wrote:

> On Wednesday, May 09, 2018 10:02:06 AM Warner Losh wrote:
> > On Wed, May 9, 2018 at 8:58 AM, John Baldwin <jhb at freebsd.org> wrote:
> >
> > > On Wednesday, May 09, 2018 02:07:09 AM Cy Schubert wrote:
> > > > Author: cy
> > > > Date: Wed May  9 02:07:09 2018
> > > > New Revision: 333393
> > > > URL: https://svnweb.freebsd.org/changeset/base/333393
> > > >
> > > > Log:
> > > >   Document intentional fallthrough. (CID 976535)
> > > >
> > > >   MFC after:  1 week
> > > >
> > > > Modified:
> > > >   head/sys/contrib/ipfilter/netinet/fil.c
> > > >
> > > > Modified: head/sys/contrib/ipfilter/netinet/fil.c
> > > > ============================================================
> > > ==================
> > > > --- head/sys/contrib/ipfilter/netinet/fil.c   Wed May  9 02:02:58
> 2018
> > >       (r333392)
> > > > +++ head/sys/contrib/ipfilter/netinet/fil.c   Wed May  9 02:07:09
> 2018
> > >       (r333393)
> > > > @@ -1299,6 +1299,7 @@ ipf_pr_icmp(fin)
> > > >                       }
> > > >               }
> > > >  #endif
> > > > +             /* fallthrough is intentional */
> > > >       case ICMP_SOURCEQUENCH :
> > > >       case ICMP_REDIRECT :
> > > >       case ICMP_TIMXCEED :
> > >
> > > Hmm, normal FreeBSD style here is to use /* FALLTHROUGH */, and there
> are
> > > three other instances of that style in ipfilter already (and none
> others
> > > using this comment style).
> > >
> >
> > /* FALLTHROUGH */ is actually an old-school lint directive that other
> tools
> > have picked up.
>
> Yes, but it is still the dominant style in the tree even if it has come
> from
> lint.
>

Agreed. I wasn't arguing, just saying it has a long history and everybody
does it today even though lint's relevance has faded.

Warner