svn commit: r333393 - head/sys/contrib/ipfilter/netinet

John Baldwin jhb at freebsd.org
Wed May 9 15:58:11 UTC 2018


On Wednesday, May 09, 2018 02:07:09 AM Cy Schubert wrote:
> Author: cy
> Date: Wed May  9 02:07:09 2018
> New Revision: 333393
> URL: https://svnweb.freebsd.org/changeset/base/333393
> 
> Log:
>   Document intentional fallthrough. (CID 976535)
>   
>   MFC after:	1 week
> 
> Modified:
>   head/sys/contrib/ipfilter/netinet/fil.c
> 
> Modified: head/sys/contrib/ipfilter/netinet/fil.c
> ==============================================================================
> --- head/sys/contrib/ipfilter/netinet/fil.c	Wed May  9 02:02:58 2018	(r333392)
> +++ head/sys/contrib/ipfilter/netinet/fil.c	Wed May  9 02:07:09 2018	(r333393)
> @@ -1299,6 +1299,7 @@ ipf_pr_icmp(fin)
>  			}
>  		}
>  #endif
> +		/* fallthrough is intentional */
>  	case ICMP_SOURCEQUENCH :
>  	case ICMP_REDIRECT :
>  	case ICMP_TIMXCEED :

Hmm, normal FreeBSD style here is to use /* FALLTHROUGH */, and there are
three other instances of that style in ipfilter already (and none others
using this comment style).

-- 
John Baldwin


More information about the svn-src-head mailing list