svn commit: r333345 - head/sys/dev/e1000

Matthew Macy mmacy at freebsd.org
Tue May 8 23:37:54 UTC 2018


Nix that. The panic is incorrect, we simply don't have anything to do
in the default case.

On Tue, May 8, 2018 at 4:31 PM, Matthew Macy <mmacy at freebsd.org> wrote:
> Can you please try the attached patch? (Note that gmail may insert
> carriage returns)
>
> -M
>
> On Tue, May 8, 2018 at 3:10 PM, Mark Johnston <markj at freebsd.org> wrote:
>> On Tue, May 08, 2018 at 01:39:45AM +0000, Matt Macy wrote:
>>> Author: mmacy
>>> Date: Tue May  8 01:39:45 2018
>>> New Revision: 333345
>>> URL: https://svnweb.freebsd.org/changeset/base/333345
>>>
>>> Log:
>>>   Sleep rather than spin in e1000 when doing long running config operations.
>>>
>>>   With r333218 it is now possible for drivers to use an sx lock and thus sleep while
>>>   waiting on long running operations rather than DELAY().
>>>
>>>   Reported by:        gallatin
>>>   Reviewed by:        sbruno
>>>   Approved by:        sbruno
>>>   MFC after:  1 month
>>>   Sponsored by:       Limelight Networks
>>>   Differential Revision:      https://reviews.freebsd.org/D14984
>>
>> I'm getting a panic during boot with this change: "unknown mac type d".
>>
>> It occurs while the driver is attaching to:
>>
>> em0 at pci0:1:0:0: class=0x020000 card=0x7044103c chip=0x105e8086 rev=0x06 hdr=0x00
>>     vendor     = 'Intel Corporation'
>>     device     = '82571EB Gigabit Ethernet Controller'
>>     class      = network
>>     subclass   = ethernet
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 82571_fix.diff
Type: text/x-patch
Size: 431 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20180508/1ea26e28/attachment.bin>


More information about the svn-src-head mailing list