svn commit: r331237 - head/sys/cam/nvme
Warner Losh
imp at FreeBSD.org
Tue Mar 20 03:37:05 UTC 2018
Author: imp
Date: Tue Mar 20 03:37:04 2018
New Revision: 331237
URL: https://svnweb.freebsd.org/changeset/base/331237
Log:
Remove some redundant MPSAFE flags.
This was pointed out in a code review I'm having trouble finding right
now, but go ahead and eliminate these.
Sponsored by: Netfix
Modified:
head/sys/cam/nvme/nvme_da.c
Modified: head/sys/cam/nvme/nvme_da.c
==============================================================================
--- head/sys/cam/nvme/nvme_da.c Tue Mar 20 03:36:51 2018 (r331236)
+++ head/sys/cam/nvme/nvme_da.c Tue Mar 20 03:37:04 2018 (r331237)
@@ -626,25 +626,20 @@ ndasysctlinit(void *context, int pending)
}
SYSCTL_ADD_INT(&softc->sysctl_ctx, SYSCTL_CHILDREN(softc->sysctl_tree),
- OID_AUTO, "unmapped_io", CTLFLAG_RD | CTLFLAG_MPSAFE,
- &softc->unmappedio, 0, "Unmapped I/O leaf");
+ OID_AUTO, "unmapped_io", CTLFLAG_RD,
+ &softc->unmappedio, 0, "Unmapped I/O leaf");
SYSCTL_ADD_QUAD(&softc->sysctl_ctx, SYSCTL_CHILDREN(softc->sysctl_tree),
- OID_AUTO, "deletes", CTLFLAG_RD | CTLFLAG_MPSAFE,
- &softc->deletes, "Number of BIO_DELETE requests");
+ OID_AUTO, "deletes", CTLFLAG_RD,
+ &softc->deletes, "Number of BIO_DELETE requests");
SYSCTL_ADD_QUAD(&softc->sysctl_ctx, SYSCTL_CHILDREN(softc->sysctl_tree),
- OID_AUTO, "dsm_req", CTLFLAG_RD | CTLFLAG_MPSAFE,
- &softc->dsm_req, "Number of DSM requests sent to SIM");
+ OID_AUTO, "dsm_req", CTLFLAG_RD,
+ &softc->dsm_req, "Number of DSM requests sent to SIM");
- SYSCTL_ADD_INT(&softc->sysctl_ctx,
- SYSCTL_CHILDREN(softc->sysctl_tree),
- OID_AUTO,
- "rotating",
- CTLFLAG_RD | CTLFLAG_MPSAFE,
- &nda_rotating_media,
- 0,
- "Rotating media");
+ SYSCTL_ADD_INT(&softc->sysctl_ctx, SYSCTL_CHILDREN(softc->sysctl_tree),
+ OID_AUTO, "rotating", CTLFLAG_RD, &nda_rotating_media, 1,
+ "Rotating media");
#ifdef CAM_IO_STATS
softc->sysctl_stats_tree = SYSCTL_ADD_NODE(&softc->sysctl_stats_ctx,
@@ -657,17 +652,17 @@ ndasysctlinit(void *context, int pending)
}
SYSCTL_ADD_INT(&softc->sysctl_stats_ctx,
SYSCTL_CHILDREN(softc->sysctl_stats_tree),
- OID_AUTO, "timeouts", CTLFLAG_RD | CTLFLAG_MPSAFE,
+ OID_AUTO, "timeouts", CTLFLAG_RD,
&softc->timeouts, 0,
"Device timeouts reported by the SIM");
SYSCTL_ADD_INT(&softc->sysctl_stats_ctx,
SYSCTL_CHILDREN(softc->sysctl_stats_tree),
- OID_AUTO, "errors", CTLFLAG_RD | CTLFLAG_MPSAFE,
+ OID_AUTO, "errors", CTLFLAG_RD,
&softc->errors, 0,
"Transport errors reported by the SIM.");
SYSCTL_ADD_INT(&softc->sysctl_stats_ctx,
SYSCTL_CHILDREN(softc->sysctl_stats_tree),
- OID_AUTO, "pack_invalidations", CTLFLAG_RD | CTLFLAG_MPSAFE,
+ OID_AUTO, "pack_invalidations", CTLFLAG_RD,
&softc->invalidations, 0,
"Device pack invalidations.");
#endif
More information about the svn-src-head
mailing list