svn commit: r330767 - head/sys/x86/isa

[Ian Lepore]

Author: ian
Date: Sun Mar 11 16:57:14 2018
New Revision: 330767
URL: https://svnweb.freebsd.org/changeset/base/330767

Log:
  Convert atrtc the new style rtc debugging output.  Remove the db show
  command handler which provided much the same information.  Removing the
  possibility of accessing the hardware regs from the debugger context
  paves the way for simplifying the locking code in the driver.

Modified:
  head/sys/x86/isa/atrtc.c

Modified: head/sys/x86/isa/atrtc.c
==============================================================================
--- head/sys/x86/isa/atrtc.c	Sun Mar 11 16:17:53 2018	(r330766)
+++ head/sys/x86/isa/atrtc.c	Sun Mar 11 16:57:14 2018	(r330767)
@@ -318,6 +318,7 @@ atrtc_settime(device_t dev __unused, struct timespec *
 	struct bcd_clocktime bct;
 
 	clock_ts_to_bcd(ts, &bct, false);
+	clock_dbgprint_bcd(dev, CLOCK_DBG_WRITE, &bct);
 
 	mtx_lock(&atrtc_time_lock);
 	RTC_LOCK;
@@ -385,6 +386,7 @@ atrtc_gettime(device_t dev, struct timespec *ts)
 	/* dow is unused in timespec conversion and we have no nsec info. */
 	bct.dow  = 0;
 	bct.nsec = 0;
+	clock_dbgprint_bcd(dev, CLOCK_DBG_READ, &bct);
 	return (clock_bcd_to_ts(&bct, ts, false));
 }
 
@@ -416,16 +418,3 @@ static devclass_t atrtc_devclass;
 DRIVER_MODULE(atrtc, isa, atrtc_driver, atrtc_devclass, 0, 0);
 DRIVER_MODULE(atrtc, acpi, atrtc_driver, atrtc_devclass, 0, 0);
 ISA_PNP_INFO(atrtc_ids);
-
-#include "opt_ddb.h"
-#ifdef DDB
-#include <ddb/ddb.h>
-
-DB_SHOW_COMMAND(rtc, rtc)
-{
-	printf("%02x/%02x/%02x %02x:%02x:%02x, A = %02x, B = %02x, C = %02x\n",
-		rtcin(RTC_YEAR), rtcin(RTC_MONTH), rtcin(RTC_DAY),
-		rtcin(RTC_HRS), rtcin(RTC_MIN), rtcin(RTC_SEC),
-		rtcin(RTC_STATUSA), rtcin(RTC_STATUSB), rtcin(RTC_INTR));
-}
-#endif /* DDB */