svn commit: r330601 - head/sys/i386/ibcs2

Pedro Giffuni pfg at FreeBSD.org
Wed Mar 7 18:20:20 UTC 2018


FWIW ...

ibcs2 is candidate for future removal.

We tried to get some vendor interest in it but we failed and given this 
is very i386-specific it is probably not worth spending huge efforts on it.

cloudabi seems to be, for all purposes, a better conceptual replacement.

Pedro.

On 07/03/2018 09:44, Eitan Adler wrote:
> Author: eadler
> Date: Wed Mar  7 14:44:32 2018
> New Revision: 330601
> URL: https://svnweb.freebsd.org/changeset/base/330601
>
> Log:
>    sys: Fix a few potential infoleaks in cloudabi
>    
>    While there is no immediate leak, if the structure changes underneath
>    us, there might be in the future.
>    
>    Submitted by:	Domagoj Stolfa <domagoj.stolfa at gmail.com>
>    MFC After:	1 month
>    Sponsored by:	DARPA/AFRL
>
> Modified:
>    head/sys/i386/ibcs2/ibcs2_ipc.c
>
> Modified: head/sys/i386/ibcs2/ibcs2_ipc.c
> ==============================================================================
> --- head/sys/i386/ibcs2/ibcs2_ipc.c	Wed Mar  7 14:41:29 2018	(r330600)
> +++ head/sys/i386/ibcs2/ibcs2_ipc.c	Wed Mar  7 14:44:32 2018	(r330601)
> @@ -135,6 +135,8 @@ ibcs2_msgctl(struct thread *td, void *v)
>   	struct msqid_ds bs;
>   	int error;
>   
> +	memset(&is, 0, sizeof(is));
> +
>   	switch (uap->cmd) {
>   	case IBCS2_IPC_STAT:
>   		error = kern_msgctl(td, uap->msqid, IPC_STAT, &bs);
> @@ -317,6 +319,8 @@ ibcs2_semctl(struct thread *td, void *v)
>   	union semun semun;
>   	register_t rval;
>   	int error;
> +
> +	memset(&is, 0, sizeof(is));
>   
>   	switch(uap->cmd) {
>   	case IBCS2_IPC_STAT:
>



More information about the svn-src-head mailing list