svn commit: r335733 - in head: bin/csh gnu/usr.bin/cc/cc1 gnu/usr.bin/cc/cc1plus gnu/usr.bin/cc/cc_tools lib/libmagic lib/libpam/static_libpam lib/ncurses/ncurses share/syscons/scrnmaps stand/mips/...

[Dimitry Andric]

On 27 Jun 2018, at 22:53, John Baldwin <jhb at freebsd.org> wrote:
> 
> On 6/27/18 12:45 PM, Bryan Drewery wrote:
>> On 6/27/2018 12:35 PM, Dimitry Andric wrote:
>>> On 27 Jun 2018, at 21:29, Bryan Drewery <bdrewery at FreeBSD.org> wrote:
>>>> 
>>>> Author: bdrewery
>>>> Date: Wed Jun 27 19:29:15 2018
>>>> New Revision: 335733
>>>> URL: https://svnweb.freebsd.org/changeset/base/335733
>>>> 
>>>> Log:
>>>> Don't use CCACHE for linking.
>>>> 
>>>> MFC after:	2 weeks
>>>> Sponsored by:	Dell EMC
>>>> 
>>>> Modified:
>>>> head/bin/csh/Makefile
>>>> head/gnu/usr.bin/cc/cc1/Makefile
>>>> head/gnu/usr.bin/cc/cc1plus/Makefile
>>>> head/gnu/usr.bin/cc/cc_tools/Makefile
>>>> head/lib/libmagic/Makefile
>>>> head/lib/libpam/static_libpam/Makefile
>>>> head/lib/ncurses/ncurses/Makefile
>>>> head/share/syscons/scrnmaps/Makefile
>>>> head/stand/mips/beri/boot2/Makefile
>>>> head/usr.bin/vi/catalog/Makefile
>>>> 
>>>> Modified: head/bin/csh/Makefile
>>>> ==============================================================================
>>>> --- head/bin/csh/Makefile	Wed Jun 27 19:28:37 2018	(r335732)
>>>> +++ head/bin/csh/Makefile	Wed Jun 27 19:29:15 2018	(r335733)
>>>> @@ -113,7 +113,7 @@ build-tools: gethost
>>>> 
>>>> gethost: gethost.c sh.err.h tc.const.h sh.h ${BUILD_TOOLS_META}
>>>> 	@rm -f ${.TARGET}
>>>> -	${CC} -o gethost ${LDFLAGS} ${CFLAGS:C/-DHAVE_ICONV//} \
>>>> +	${CC:N${CCACHE_BIN}} -o gethost ${LDFLAGS} ${CFLAGS:C/-DHAVE_ICONV//} \
>>>> 	    ${TCSHDIR}/gethost.c
>>> 
>>> Looks like a good candidate for a common macro, say CC_NOCACHE, CC_REAL
>>> or something like that? :)
>> 
>> Yeah probably. I'd paint it CC_LINK.
> 
> CCLD was my initial thought *duck*

Actually, that is not bad, and something I have seem more often.  In the
sense that ${LD} would be e.g. /usr/bin/ld or at least, a "low level"
linker, while ${CCLD} would be the compiler driver doing the work.
Maybe it is specifically for these cases, that you don't directly use
${CC}, but ${CCLD}...

-Dimitry

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 223 bytes
Desc: Message signed with OpenPGP
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20180628/af7dd644/attachment.sig>