svn commit: r335547 - head/usr.bin/top

[Cy Schubert]

In message <20180623161656.GB91517 at FreeBSD.org>, Alexey Dokuchaev 
writes:
> On Fri, Jun 22, 2018 at 09:45:18AM +0000, Eitan Adler wrote:
> > New Revision: 335547
> > URL: https://svnweb.freebsd.org/changeset/base/335547
> > 
> > Log:
> >   top(1): remove special handling of load > 5
> >   
> > ...
> > Modified: head/usr.bin/top/screen.c
> > ===========================================================================
> ===
> > --- head/usr.bin/top/screen.c	Fri Jun 22 09:41:13 2018	(r33554
> 6)
> > +++ head/usr.bin/top/screen.c	Fri Jun 22 09:45:18 2018	(r33554
> 7)
> > @@ -55,7 +55,7 @@ static struct termios new_settings;
> >  static char is_a_terminal = false;
> >  
> >  void
> > -init_termcap(int interactive)
> > +init_termcap(bool interactive)
> >  {
> >      char *bufptr;
> >      char *PCptr;
> > @@ -138,7 +138,7 @@ init_termcap(int interactive)
> >      /* get "ce", clear to end */
> >      if (!overstrike)
> >      {
> > -	clear_line = tgetstr("ce", &bufptr);
> > +		clear_line = tgetstr("ce", &bufptr);
> >      }
>
> (I've seen it before, and replying to this commit as an example): would
> you mind separating style and functional changes into different commits?
> I know that top(1) is full of style bugs and it's very tempting to fix
> them when you see them, but that's not really the best way to go.

Agreed. My src commit bit mentor made sure I separated functional from 
style commits. Having been a prior ports committer, we on the ports 
side batch commits all the time but when glebius pointed this out to me 
I understood the reason why and I now try to do the same on the ports 
side of the fence too. It's more difficult it but IMO well worth it. I 
find that git helps separate these types of commits -- if I make a 
mistake it's easy enough to back out a git commit and do it again 
before git svn dcommit.

Just my $0.02.


-- 
Cheers,
Cy Schubert <Cy.Schubert at cschubert.com>
FreeBSD UNIX:  <cy at FreeBSD.org>   Web:  http://www.FreeBSD.org

	The need of the many outweighs the greed of the few.