svn commit: r334862 - head/sys/net

Stephen Hurd shurd at FreeBSD.org
Fri Jun 8 21:49:20 UTC 2018


Author: shurd
Date: Fri Jun  8 21:49:19 2018
New Revision: 334862
URL: https://svnweb.freebsd.org/changeset/base/334862

Log:
  Remove tx task spinning added in r333686
  
  This caused issues with PASTE.  Just remove the reschedule since the DELAY()
  should be enough for use cases such as pkt-gen which were failing before the
  change.
  
  Reported by:	Michio Honda
  Sponsored by:	Limelight Networks

Modified:
  head/sys/net/iflib.c

Modified: head/sys/net/iflib.c
==============================================================================
--- head/sys/net/iflib.c	Fri Jun  8 21:47:17 2018	(r334861)
+++ head/sys/net/iflib.c	Fri Jun  8 21:49:19 2018	(r334862)
@@ -3728,16 +3728,6 @@ _task_fn_tx(void *context)
 		 */
 		if (ctx->isc_txd_credits_update(ctx->ifc_softc, txq->ift_id, false))
 			netmap_tx_irq(ifp, txq->ift_id);
-		else {
-#ifdef DEV_NETMAP			
-			if (!(ctx->ifc_flags & IFC_NETMAP_TX_IRQ)) {
-				struct netmap_kring *kring = NA(ctx->ifc_ifp)->tx_rings[txq->ift_id];
-
-				if (kring->nr_hwtail != nm_prev(kring->rhead, kring->nkr_num_slots - 1))
-					GROUPTASK_ENQUEUE(&txq->ift_task);
-			}
-#endif			
-		}
 		IFDI_TX_QUEUE_INTR_ENABLE(ctx, txq->ift_id);
 		return;
 	}


More information about the svn-src-head mailing list