svn commit: r334669 - head/sys/sys

[Andriy Gapon]

On 06/06/2018 00:07, Eric van Gyzen wrote:
> On 06/05/2018 15:53, Ian Lepore wrote:
>> This is a sad sad thing. Treating (bits & flagconstants) as boolean has
>> a long long history in C. Surely there are literally thousand of
>> occurrances in freebsd code already, so why did this one get flagged?
> 
> I agree, and I tend to avoid adding "!= 0" unnecessarily, but I don't
> feel very strongly about it.  

I am not sure what parts of code you work on, but turning bit operations into
logical operations within conditions is the predominant FreeBSD style.
Please accept it.


-- 
Andriy Gapon