svn commit: r336744 - in head: sbin/pfctl/tests/files share/mk

[Mark Millard]

On 2018-Jul-28, at 8:59 PM, Brad Davis <brd at FreeBSD.org> wrote:

> On Sat, Jul 28, 2018, at 9:53 PM, Mark Millard wrote:
>> Brad Davis brd at FreeBSD.org wrote on
>> Thu Jul 26 17:11:15 UTC 2018 :
>> 
>>> On Thu, Jul 26, 2018, at 11:09 AM, Shawn Webb wrote:
>>> . . .
>>>>> -FILES=		${.CURDIR}/pf????.in
>>>>> -FILES+=		${.CURDIR}/pf????.include
>>>>> -FILES+=		${.CURDIR}/pf????.ok
>>>>> +FILES!=		echo ${.CURDIR}/pf????.in ${.CURDIR}/pf????.include ${.CURDIR}/pf????.ok
>>>> 
>>>> Should this use ${ECHO} instead of echo?
>>> 
>>> 
>>> No, that wouldn't work at all with the !=.
>> 
>> /usr/ports/Mk/bsd.port.mk has things like:
>> 
>> OPSYS!=	${UNAME} -s
>> and:
>> _OSRELEASE!=	${UNAME} -r
>> 
>> Is your ${ECHO} note specific to the combination of ${ECHO} and !=
>> for some reason --or does it apply to the likes of ${UNAME} mixed
>> with != too?
> 
> That is different.. due to share/mk/sys.mk has:
> 
> .if empty(.MAKEFLAGS:M-s)
> ECHO            ?=      echo
> ECHODIR         ?=      echo
> .else
> ECHO            ?=      true
> .if ${.MAKEFLAGS:M-s} == "-s"
> ECHODIR         ?=      echo
> .else
> ECHODIR         ?=      true
> .endif
> .endif
> 
> Which means if someone is using make -s, these tests would not install.. which is probably not what is desired and there are better ways to do that.


Thanks.

Looking around I see that /usr/ports/Mk/bsd.commands.mk has:

# ECHO is defined in /usr/share/mk/sys.mk, which can either be "echo",
# or "true" if the make flag -s is given.  Use ECHO_CMD where you mean
# the echo command.
ECHO_CMD?=              echo    # Shell builtin

# Used to print all the '===>' style prompts - override this to turn them off.
ECHO_MSG?=              ${ECHO_CMD}


So may be ${ECHO_CMD} would be an alternate to echo.

===
Mark Millard
marklmi at yahoo.com
( dsl-only.net went
away in early 2018-Mar)