svn commit: r336845 - in head: etc etc/defaults etc/rc.d sbin/init sbin/init/rc.d

[Brad Davis]

On Sun, Jul 29, 2018, at 12:33 PM, Konstantin Belousov wrote:
> On Sun, Jul 29, 2018 at 11:51:32AM -0600, Brad Davis wrote:
> > On Sun, Jul 29, 2018, at 11:44 AM, Konstantin Belousov wrote:
> > > On Sun, Jul 29, 2018 at 11:01:27AM -0600, Brad Davis wrote:
> > > > On Sun, Jul 29, 2018, at 9:42 AM, Konstantin Belousov wrote:
> > > > > On Sat, Jul 28, 2018 at 08:36:23PM +0000, Brad Davis wrote:
> > > > > > Author: brd
> > > > > > Date: Sat Jul 28 20:36:23 2018
> > > > > > New Revision: 336845
> > > > > > URL: https://svnweb.freebsd.org/changeset/base/336845
> > > > > > 
> > > > > > Log:
> > > > > >   Move rc startup scripts from etc/ to sbin/init/
> > > > > Why all these moves are useful ?
> > > > > 
> > > > > No commit message explained what is the goal of the moves, and why
> > > > > it is better that way comparing the existing src/etc collection.
> > > > 
> > > > For pkg base we need to distill things out of etc/ and into places
> > > > where they fit better. This enables them to be pkged up with the
> > > > parts of the system them belong with and the CONFS= tags them as
> > > > config files so that pkg will know about them and be able to 3-way
> > > > merge them. This keeps the flexibility we have today with the many
> > > > WITH_*/WITHOUT_* knobs. Though it is not without trade offs, keeping
> > > > all of one part of the system together is simpler and makes some
> > > > maintenance easier.
> > > I do not see why do we need this for the pkgbase.  There is nothing
> > > wrong with installation of the whole clean dist-supplied /etc on
> > > the fresh system.  More, as you noted yourself, the ability to have
> > > all the config files installed is simpler and allows to overview and
> > > prepare configuration without requiring to have the corresponding
> > > packages installed.
> > 
> > On a fresh system sure, but on upgrades that is a problem.
> > 
> > I was not advocating for having all the etc files installed, even when you do not have that pkg installed.  I am saying it matches what happens today if you have, for example, WITHOUT_ACPI=y set.
> > 
> All of this should have been written, perhaps even with more details,
> in the commit message.

You are right, I will working on improving my commit messages.


Regards,
Brad Davis