svn commit: r336526 - head

[Ravi Pokala]

-----Original Message-----
From: Ravi Pokala <rpokala at freebsd.org>
Date: 2018-07-20, Friday at 10:53
To: Ian Lepore <ian at freebsd.org>, <src-committers at freebsd.org>, <svn-src-all at freebsd.org>, <svn-src-head at freebsd.org>, Will Andrews <will at FreeBSD.org>
Subject: Re: svn commit: r336526 - head

> -----Original Message-----
> From: <owner-src-committers at freebsd.org> on behalf of Ian Lepore <ian at freebsd.org>
> Date: 2018-07-20, Friday at 10:38
> To: Ravi Pokala <rpokala at freebsd.org>, <src-committers at freebsd.org>, <svn-src-all at freebsd.org>, <svn-src-head at freebsd.org>
> Subject: Re: svn commit: r336526 - head
> 
>> On Fri, 2018-07-20 at 09:56 -0700, Ravi Pokala wrote:
>>> Hi Ian,
>>> 
>>> -----Original Message-----
>>> From: <owner-src-committers at freebsd.org> on behalf of Ian Lepore 
>>> Date: 2018-07-19, Thursday at 17:44
>>> To: <src-committers at freebsd.org>, <svn-src-all at freebsd.org>, 
>>> Subject: svn commit: r336526 - head
>>> 
>>>> 
>>>> Author: ian
>>>> Date: Fri Jul 20 00:44:04 2018
>>>> New Revision: 336526
>>>> URL: https://svnweb.freebsd.org/changeset/base/336526
>>>> 
>>>> Log:
>>>>   Add ntpd to the list of users/groups to check before installing.
>>>> 
>>>> Modified:
>>>>   head/Makefile.inc1
>>> When trying to installworld:
>>> 
>>>     ERROR: Required ntpd user is missing, see /usr/src/UPDATING.
>>> 
>>> But there is no UPDATING entry about this. (Also, shouldn't it be ${SRCTOP}/UPDATING?)
>>> 
>>> Thanks,
>>> 
>>> Ravi (rpokala@)
>> 
>> I wondered about that too, when I accidentally stumbled across the
>> CHECK_UIDS thing and realized I should add ntpd to it. I searched in
>> UPDATING for some of the other things in the CHECK_UIDS list to see
>> what had been said about such changes in the past, even searching
>> through old-old svn history, and found nothing.
>> 
>> I finally settled on the thought that the reference to UPDATING was to
>> the stuff at the bottom that never changes. In particular to the
>> section around line 1595 that documents the instalkernel, reboot,
>> mergemaster, installworld sequence. The mergemaster part should take
>> care of the new userid, I guess.
>> 
>> -- Ian
> 
> Interesting. I was attempting the install via the `beinstall.sh' script. CCing will@, since he wrote it.
> 
> Thanks,
> 
> Ravi (rpokala@)

After some discussion on IRC, I created this patch to fix `beinstall.sh'.

    https://people.freebsd.org/~rpokala/beinstall.patch

However, I'm a bit afraid of testing it, until someone who actually knows `etcupdate' and `mergemaster' can confirm that it won't blow up my box. :-)

Can anyone take a look and assuage my fears?

Thanks,

Ravi (rpokala@)