svn commit: r336526 - head

[Warner Losh]

On Fri, Jul 20, 2018 at 11:38 AM, Ian Lepore <ian at freebsd.org> wrote:

> On Fri, 2018-07-20 at 09:56 -0700, Ravi Pokala wrote:
> > Hi Ian,
> >
> > -----Original Message-----
> > From: <owner-src-committers at freebsd.org> on behalf of Ian Lepore
> > Date: 2018-07-19, Thursday at 17:44
> > To: <src-committers at freebsd.org>, <svn-src-all at freebsd.org>,
> > Subject: svn commit: r336526 - head
> >
> > >
> > > Author: ian
> > > Date: Fri Jul 20 00:44:04 2018
> > > New Revision: 336526
> > > URL: https://svnweb.freebsd.org/changeset/base/336526
> > >
> > > Log:
> > >   Add ntpd to the list of users/groups to check before installing.
> > >
> > > Modified:
> > >   head/Makefile.inc1
> > When trying to installworld:
> >
> >     ERROR: Required ntpd user is missing, see /usr/src/UPDATING.
> >
> > But there is no UPDATING entry about this. (Also, shouldn't it be
> ${SRCTOP}/UPDATING?)
> >
> > Thanks,
> >
> > Ravi (rpokala@)
>
> I wondered about that too, when I accidentally stumbled across the
> CHECK_UIDS thing and realized I should add ntpd to it. I searched in
> UPDATING for some of the other things in the CHECK_UIDS list to see
> what had been said about such changes in the past, even searching
> through old-old svn history, and found nothing.
>
> I finally settled on the thought that the reference to UPDATING was to
> the stuff at the bottom that never changes. In particular to the
> section around line 1595 that documents the instalkernel, reboot,
> mergemaster, installworld sequence. The mergemaster part should take
> care of the new userid, I guess.
>

It should. While what you say is true, it's also been true that in the past
people have often listed new userid's in the UPDATING text at the top to
give people more info about whether or not it's safe to skip mergemaster
and/or make alternative plans if it isn't and they don't use mergemaster :)

Warner