svn commit: r336028 - head/usr.bin/top

後藤大地 daichigoto at icloud.com
Sat Jul 7 11:39:42 UTC 2018


> 2018/07/07 8:53、Hiroki Sato <hrs at FreeBSD.org>のメール:
> 
> Daichi GOTO <daichi at FreeBSD.org> wrote
>  in <201807061207.w66C76CR043533 at repo.freebsd.org>:
> 
> da> Author: daichi
> da> Date: Fri Jul  6 12:07:06 2018
> da> New Revision: 336028
> da> URL: https://svnweb.freebsd.org/changeset/base/336028
> da>
> da> Log:
> da>   Changed to eliminate the upper limit of command length displayed
> da>   by "-a" and expand to match terminal width
> da>
> da>   Reviewed by:	eadler
> da>   Approved by:	gnn (mentor)
> da>   Differential Revision:	https://reviews.freebsd.org/D16083
> da>
> da> Modified:
> da>   head/usr.bin/top/display.c
> da>   head/usr.bin/top/machine.c
> da>   head/usr.bin/top/screen.c
> da>   head/usr.bin/top/top.h
> 
> This change breaks displaying a prompt and messages in the
> interactive mode by new_message() when typing "o" or "p", for
> example.  While r336031 fixed a warning in GCC, it does not fix the
> problem itself.  Please fix it.

OK. I will fix this problem first.


> I also think restructure of the buffer management is required first
> if we want to eliminate the column width limitation.  Using sbuf(9)
> consistently may be better than incomplete conversion from static
> arrays to malloc().

I understand. Switching to sbuf(9) is the next step.

> 
> -- Hiroki



More information about the svn-src-head mailing list