svn commit: r335906 - head/sys/conf

[Cy Schubert]

In message <6d02404f-a7bb-01c7-3775-7a0349e306be at FreeBSD.org>, Bryan 
Drewery wr
ites:
> This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
> --nrEq6SIfsbZGYTgfSZ5R3mSN64FvoLCIQ
> Content-Type: multipart/mixed; boundary="N66uQifSC1aSf1iMifRJdrqNP6RkoOJg1";
>  protected-headers="v1"
> From: Bryan Drewery <bdrewery at FreeBSD.org>
> To: Cy Schubert <Cy.Schubert at cschubert.com>
> Cc: src-committers at freebsd.org, svn-src-all at freebsd.org,
>  svn-src-head at freebsd.org
> Message-ID: <6d02404f-a7bb-01c7-3775-7a0349e306be at FreeBSD.org>
> Subject: Re: svn commit: r335906 - head/sys/conf
> References: <201807031959.w63JxPA2069044 at slippy.cwsent.com>
> In-Reply-To: <201807031959.w63JxPA2069044 at slippy.cwsent.com>
>
> --N66uQifSC1aSf1iMifRJdrqNP6RkoOJg1
> Content-Type: text/plain; charset=utf-8
> Content-Language: en-US
> Content-Transfer-Encoding: quoted-printable
>
> On 7/3/2018 12:59 PM, Cy Schubert wrote:
> > In message <201807031924.w63JOi5W051614 at repo.freebsd.org>, Bryan=20
> > Drewery writes
> > :
> >> Author: bdrewery
> >> Date: Tue Jul  3 19:24:44 2018
> >> New Revision: 335906
> >> URL: https://svnweb.freebsd.org/changeset/base/335906
> >>
> >> Log:
> >>   No need to make a copy to build genoffset_test.o
> >>
> >> Modified:
> >>   head/sys/conf/kern.post.mk
> >>
> >> Modified: head/sys/conf/kern.post.mk
> >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> =3D=3D=3D
> >> =3D
> >> --- head/sys/conf/kern.post.mk	Tue Jul  3 19:09:46 2018	(r33590
> >> 5)
> >> +++ head/sys/conf/kern.post.mk	Tue Jul  3 19:24:44 2018	(r33590
> >> 6)
> >> @@ -191,14 +191,12 @@ offset.inc: $S/kern/genoffset.sh genoffset.o
> >>  genoffset.o: $S/kern/genoffset.c
> >>  	${CC} -c ${CFLAGS:N-flto:N-fno-common} $S/kern/genoffset.c
> >> =20
> >> -genoffset_test.c: $S/kern/genoffset.c
> >> -	cp $S/kern/genoffset.c genoffset_test.c
> >> -
> >>  # genoffset_test.o is not actually used for anything - the point of c=
> ompilin
> >> g it
> >>  # is to exercise the CTASSERT that checks that the offsets in the off=
> set.inc
> >>  # _lite struct(s) match those in the original(s).=20
> >> -genoffset_test.o: genoffset_test.c offset.inc
> >> -	${CC} -c ${CFLAGS:N-flto:N-fno-common} -DOFFSET_TEST genoffset_test.=
> c
> >> +genoffset_test.o: $S/kern/genoffset.c offset.inc
> >> +	${CC} -c ${CFLAGS:N-flto:N-fno-common} -DOFFSET_TEST ${.ALLSRC:M*.c}=
>  \
> >> +	    -o ${.TARGET}
> >=20
> > -o with -c in the previous line will cause an error.
>
> -o and -c are fine together. The problem is .ALLSRC duplicating sources
> from the dependencies read from .depend.genoffset_test.o file.
> Workaround in r335908.

gotcha.

Sorry for the second spam.


-- 
Cheers,
Cy Schubert <Cy.Schubert at cschubert.com>
FreeBSD UNIX:  <cy at FreeBSD.org>   Web:  http://www.FreeBSD.org

	The need of the many outweighs the greed of the few.