svn commit: r328559 - head/contrib/netbsd-tests/usr.bin/grep

Kyle Evans kevans at FreeBSD.org
Mon Jan 29 18:50:46 UTC 2018


Author: kevans
Date: Mon Jan 29 18:50:45 2018
New Revision: 328559
URL: https://svnweb.freebsd.org/changeset/base/328559

Log:
  Remove t_grep:mmap_eof_not_eol test
  
  The test was marked as an expected failure in r320414 after r319971's import
  of a newer jemalloc removed an essential feature (opt.redzone) for
  reproducing the behavior it was testing. Since then, no way has been found
  or demonstrated to reliably test the behavior, so remove the test.
  
  PR:		220309

Modified:
  head/contrib/netbsd-tests/usr.bin/grep/t_grep.sh

Modified: head/contrib/netbsd-tests/usr.bin/grep/t_grep.sh
==============================================================================
--- head/contrib/netbsd-tests/usr.bin/grep/t_grep.sh	Mon Jan 29 18:49:28 2018	(r328558)
+++ head/contrib/netbsd-tests/usr.bin/grep/t_grep.sh	Mon Jan 29 18:50:45 2018	(r328559)
@@ -646,30 +646,6 @@ mmap_body()
 	atf_check -s exit:1 grep --mmap -e "Z" test1
 }
 
-atf_test_case mmap_eof_not_eol
-mmap_eof_not_eol_head()
-{
-	atf_set "descr" "Check --mmap flag handling of encountering EOF without EOL (PR 165471, 219402)"
-}
-mmap_eof_not_eol_body()
-{
-	grep_type
-	if [ $? -eq $GREP_TYPE_GNU ]; then
-		atf_expect_fail "gnu grep from ports has no --mmap option"
-	fi
-
-	atf_expect_fail "relies on jemalloc feature no longer available; needs to be rewritten - bug 220309"
-
-	printf "ABC" > test1
-	jot -b " "  -s "" 4096 >> test2
-
-	atf_check -s exit:0 -o inline:"B\n" grep --mmap -oe "B" test1
-	# Dependency on jemalloc(3) to detect buffer overflow, otherwise this
-	# unreliably produces a SIGSEGV or SIGBUS
-	atf_check -s exit:0 -o not-empty \
-	    env MALLOC_CONF="redzone:true" grep --mmap -e " " test2
-}
-
 atf_test_case matchall
 matchall_head()
 {
@@ -779,7 +755,6 @@ atf_init_test_cases()
 	atf_add_test_case binary_flags
 	atf_add_test_case badcontext
 	atf_add_test_case mmap
-	atf_add_test_case mmap_eof_not_eol
 	atf_add_test_case matchall
 	atf_add_test_case fgrep_multipattern
 	atf_add_test_case fgrep_icase


More information about the svn-src-head mailing list