svn commit: r328486 - head/usr.bin/fortune/fortune

Ian Lepore ian at freebsd.org
Sat Jan 27 23:09:03 UTC 2018


On Sat, 2018-01-27 at 22:56 +0000, Conrad Meyer wrote:
> I don’t think dragonfly has anything to do with this?  If you’re
> converting
> bool increments to setting true values in FreeBSD, use
> “true.”  That’s all
> there is to it.
> 
> Best,
> Conrad

style(9) emphasizes internal consistancy in several places.  The
uppercase TRUE/FALSE is currently the style within that code, so it
makes sense to stick with it.  If a (somewhat gratuitous) conversion to
the new style is made, it should be a separate commit just for that,
emphasizing that it changes just style and not functionality.

-- Ian


More information about the svn-src-head mailing list