svn commit: r328493 - head/lib/libthr/thread

Pedro Giffuni pfg at FreeBSD.org
Sat Jan 27 22:58:57 UTC 2018


For the record ...

On 01/27/18 17:27, Pedro F. Giffuni wrote:
> Author: pfg
> Date: Sat Jan 27 22:27:55 2018
> New Revision: 328493
> URL: https://svnweb.freebsd.org/changeset/base/328493
>
> Log:
>    libthr: Fix missing break in switch.
>   
Hmm..
There is no "missing break" I just copy/pasted the Coverity report (a 
false positive).
Sorry if that confused people.

Pedro.

>    This is also a warning in recent GCC with -Wimplicit-fallthrough.
>    
>    CID:	1356262
>    Obtained from:	DragonFly (git 0f037c78 - partial)
>
> Modified:
>    head/lib/libthr/thread/thr_printf.c
>
> Modified: head/lib/libthr/thread/thr_printf.c
> ==============================================================================
> --- head/lib/libthr/thread/thr_printf.c	Sat Jan 27 22:16:19 2018	(r328492)
> +++ head/lib/libthr/thread/thr_printf.c	Sat Jan 27 22:27:55 2018	(r328493)
> @@ -95,6 +95,7 @@ next:			c = *fmt++;
>   			case 'p':
>   				pstr(fd, "0x");
>   				islong = 1;
> +				/* FALLTHROUGH */
>   			case 'd':
>   			case 'u':
>   			case 'x':
>



More information about the svn-src-head mailing list