svn commit: r328257 - in head/sys: arm/broadcom/bcm2835 dts/arm modules

[Oleksandr Tymoshenko]

Adrian Chadd (adrian.chadd at gmail.com) wrote:
> Hi,
> 
> Find the middle ground. Don't dissuade the developer too much.
> 
> Here's an example:
> 
> Make the driver follow DTS, allow a tunable/kenv check for it to
> override whether it needs to be in the DTS or not (the "keep phk happy
> for now" compromise) and have it default to obeying the device tree.
> 
> That way phk is kept happy and the defaults are the same as normal-ish
> ARM /and/ you have a springboard to experiment with extending FDT
> overlays at runtime for people who wish to do so.

This doesn't sound right. I'm 100% with manu@ on this: driver needs to
be modified to follow DTS. A lot of work was spent to get FreeBSD FDT
support consistent over multiple platforms and to make sure it conforms
standard. When it comes to FDT support Pi port is inferior to the
majority of platforms that have been added later. I bear a fair share of
responsibility for this mess and it makes me appreciate all the effort
spent on correcting the situation even more.

Adding changes that violate standard and undermine all that work for
the convenience of a single developer is plain wrong. If current
framework is not good enough the way to go is to improve it, not hack
around its limitations

-- 
gonzo