svn commit: r328430 - head/sbin/devd

[Warner Losh]

On Thu, Jan 25, 2018 at 9:40 PM, Eitan Adler <eadler at freebsd.org> wrote:

> Author: eadler
> Date: Fri Jan 26 04:40:41 2018
> New Revision: 328430
> URL: https://svnweb.freebsd.org/changeset/base/328430
>
> Log:
>   devd: minor nits
>
>   - mark usage as noreturn
>   - config does not need a virtual destructor
>

Everything needs a virtual destructor...  Please back that part of this
out...

Warner



> Modified:
>   head/sbin/devd/devd.cc
>   head/sbin/devd/devd.hh
>
> Modified: head/sbin/devd/devd.cc
> ============================================================
> ==================
> --- head/sbin/devd/devd.cc      Fri Jan 26 04:32:31 2018        (r328429)
> +++ head/sbin/devd/devd.cc      Fri Jan 26 04:40:41 2018        (r328430)
> @@ -161,7 +161,7 @@ static const char *configfile = CF;
>  static void devdlog(int priority, const char* message, ...)
>         __printflike(2, 3);
>  static void event_loop(void);
> -static void usage(void);
> +static void usage(void) __dead2;
>
>  template <class T> void
>  delete_and_clear(vector<T *> &v)
>
> Modified: head/sbin/devd/devd.hh
> ============================================================
> ==================
> --- head/sbin/devd/devd.hh      Fri Jan 26 04:32:31 2018        (r328429)
> +++ head/sbin/devd/devd.hh      Fri Jan 26 04:40:41 2018        (r328430)
> @@ -147,7 +147,7 @@ class config
>  {
>  public:
>         config() { push_var_table(); }
> -       virtual ~config() { reset(); }
> +       ~config() { reset(); }
>         void add_attach(int, event_proc *);
>         void add_detach(int, event_proc *);
>         void add_directory(const char *);
>
>