svn commit: r328259 - in head: share/man/man4 sys/arm/broadcom/bcm2835

Alexey Dokuchaev danfe at FreeBSD.org
Mon Jan 22 07:48:38 UTC 2018


On Mon, Jan 22, 2018 at 07:43:54AM +0000, Poul-Henning Kamp wrote:
> New Revision: 328259
> URL: https://svnweb.freebsd.org/changeset/base/328259
> 
> Log:
>   Add skeleton manual page for bcm283x_pwm
>   
>   (Feel free to improve this)
> 
> Added:
>   head/share/man/man4/bcm283x_pwm.4   (contents, props changed)
> Modified:
>   head/share/man/man4/Makefile
>   head/sys/arm/broadcom/bcm2835/bcm2835_clkman.c
> 
> ...
> Modified: head/sys/arm/broadcom/bcm2835/bcm2835_clkman.c
> ==============================================================================
> --- head/sys/arm/broadcom/bcm2835/bcm2835_clkman.c	Mon Jan 22 07:15:24 2018	(r328258)
> +++ head/sys/arm/broadcom/bcm2835/bcm2835_clkman.c	Mon Jan 22 07:43:54 2018	(r328259)
> @@ -150,13 +150,13 @@ bcm2835_clkman_set_frequency(device_t dev, uint32_t un
>  	u = 500000000/hz;
>  	if (u < 4) {
>  		device_printf(sc->sc_dev,
> -		    "Frequency too high for unit 0x%x (max: 125MHz)",
> +		    "Frequency too high for unit 0x%x (max: 125 MHz)",
>  		    unit);
>  		return (0);
>  	}
>  	if (u > 0xfff) {
>  		device_printf(sc->sc_dev,
> -		    "Frequency too low for unit 0x%x (min: 123Hz)",
> +		    "Frequency too low for unit 0x%x (min: 123 kHz)",
>  		    unit);

These changes look unrelated to the manual page.  Is this intended?
On a related note, this code contains a number of style bugs, you might
want to do a quick sweep on fixing them.

./danfe


More information about the svn-src-head mailing list