svn commit: r328129 - head/sys/fs/nfsserver

[Emmanuel Vadot]

On Thu, 18 Jan 2018 22:15:16 +0000
Rick Macklem <rmacklem at uoguelph.ca> wrote:

> Emmanuel Vadot wrote:
> >> Author: manu
> >> Date: Thu Jan 18 15:28:49 2018
> >> New Revision: 328129
> >> URL: https://svnweb.freebsd.org/changeset/base/328129
> >>
> >> Log:
> >>   nfs: Do not printf each time a lock structure is freed during module unload
> >>
> >>   There can be a lot of those structures and printing a line each time we free
> >>   one on module unload.
> >
> > Finishing the sentence :
> >
> > There can be a lot of those structures and printing a line each time
> >we free one on module unload is really time consuming, especially when
> >you have a serial console plugged in.
> 
>  I will note that when I put a printf() like this in the code, it is because I
> consider it an abnormal occurrence. It might be better to at least print
> the message once.

 So should we warn once or maybe return EBUSY on unloading if there is
still lock structures ?

> For this case, normally all lock structures should go away when clients
> unmount and unloading the nfsd module while there are active mounts
> is not a safe practice. (Again NFSv4 isn't like NFSv3, there is server state
> for NFSv4.)
> 
> rick


-- 
Emmanuel Vadot <manu at bidouilliste.com> <manu at freebsd.org>