svn commit: r327699 - head/sys/sys

[Conrad Meyer]

On Mon, Jan 8, 2018 at 12:54 PM, Pedro Giffuni <pfg at freebsd.org> wrote:
> Yeah, I understand where that comes from and I will take it into account for
> future commits, but I think it should be *documented* and not assume that
> everybody  thinks that is the way version control is supposed to be used.

If you want to document it somewhere, I don't think anyone will stop
you.  In general, we do have a bunch of unwritten guidelines that are
either inferred from reading SVN log / source or explicitly requested
via review (pre- or post-commit).  I don't think it would hurt to
document.

I don't know if this specific topic is really a FreeBSD guideline or
not, but it's a good practice when using any version control system.
(You could do the same thing with 'git revert' — make additions on top
of the revert commit — and it would be equally a bad practice with
that tool.)

The only downsides I see are:

0. No one is interested in spending time writing this down and dealing
with the inevitable bikeshedding,
1. Consensus may shift over time, and
2. People don't want to spend a ton of time reading rules

Best,
Conrad