svn commit: r330128 - head/sys/arm/allwinner

Kyle Evans kevans at FreeBSD.org
Wed Feb 28 20:51:21 UTC 2018


Author: kevans
Date: Wed Feb 28 20:51:21 2018
New Revision: 330128
URL: https://svnweb.freebsd.org/changeset/base/330128

Log:
  Revert r328964: if_awg: Skip emac reset if configured for internal PHY
  
  This broke EFI boots consistently, and emac reset is sometimes needed if
  things get into a bad state -- this won't be done without a full powercycle.

Modified:
  head/sys/arm/allwinner/if_awg.c

Modified: head/sys/arm/allwinner/if_awg.c
==============================================================================
--- head/sys/arm/allwinner/if_awg.c	Wed Feb 28 20:06:03 2018	(r330127)
+++ head/sys/arm/allwinner/if_awg.c	Wed Feb 28 20:51:21 2018	(r330128)
@@ -1834,11 +1834,9 @@ awg_attach(device_t dev)
 	awg_get_eaddr(dev, eaddr);
 
 	/* Soft reset EMAC core */
-	if (!awg_has_internal_phy(dev)) {
-		error = awg_reset(dev);
-		if (error != 0)
-			return (error);
-	}
+	error = awg_reset(dev);
+	if (error != 0)
+		return (error);
 
 	/* Setup DMA descriptors */
 	error = awg_setup_dma(dev);


More information about the svn-src-head mailing list