svn commit: r328612 - head/lib/libc/stdlib

[John Baldwin]

On Sunday, February 25, 2018 07:52:49 AM Alan Somers wrote:
> I'm seeing the same error during the build of usr.sbin/nologin for
> riscv.riscv64sf.  Has anybody figured out a solution yet?

It's kind of messy.  I have a WIP patch series here:

https://github.com/freebsd/freebsd/compare/master...bsdjhb:softfloat_symbol_map

I'm trying to determine if we should just be ditching more of the soft-float
stuff from libc in favor of compiler-rt instead.  I think with my current tree
I still have a (different) breakage on riscv64sf.
 
> On Thu, Feb 1, 2018 at 9:09 PM, Warner Losh <imp at bsdimp.com> wrote:
> 
> >
> >
> > On Thu, Feb 1, 2018 at 8:34 PM, Steve Wills <swills at freebsd.org> wrote:
> >
> >> This, somehow, seems to have broken the mips64 build:
> >>
> >> https://ci.freebsd.org/job/FreeBSD-head-mips64-build/216/consoleFull
> >>
> >> The previous rev works.
> >>
> >
> > This breaks devd, of all things, with
> >
> > /usr/obj/usr/src/mips.mips64/tmp/usr/lib/libgcc.a(comparedf2.o): In
> > function `__gedf2':
> > /usr/src/contrib/compiler-rt/lib/builtins/comparedf2.c:96: multiple
> > definition of `__gedf2'
> > /usr/obj/usr/src/mips.mips64/tmp/usr/lib/libc.a(gedf2.o):/
> > usr/src/lib/libc/softfloat/gedf2.c:18: first defined here
> > /usr/obj/usr/src/mips.mips64/tmp/usr/lib/libgcc.a(comparedf2.o): In
> > function `__eqdf2':
> > /usr/src/contrib/compiler-rt/lib/builtins/comparedf2.c:126: multiple
> > definition of `__eqdf2'
> > /usr/obj/usr/src/mips.mips64/tmp/usr/lib/libc.a(eqdf2.o):/
> > usr/src/lib/libc/softfloat/eqdf2.c:18: first defined here
> > /usr/obj/usr/src/mips.mips64/tmp/usr/lib/libgcc.a(comparedf2.o): In
> > function `__ltdf2':
> > /usr/src/contrib/compiler-rt/lib/builtins/comparedf2.c:131: multiple
> > definition of `__ltdf2'
> > /usr/obj/usr/src/mips.mips64/tmp/usr/lib/libc.a(ltdf2.o):/
> > usr/src/lib/libc/softfloat/ltdf2.c:18: first defined here
> > /usr/obj/usr/src/mips.mips64/tmp/usr/lib/libgcc.a(comparedf2.o): In
> > function `__nedf2':
> > /usr/src/contrib/compiler-rt/lib/builtins/comparedf2.c:136: multiple
> > definition of `__nedf2'
> > /usr/obj/usr/src/mips.mips64/tmp/usr/lib/libc.a(nedf2.o):/
> > usr/src/lib/libc/softfloat/nedf2.c:18: first defined here
> > /usr/obj/usr/src/mips.mips64/tmp/usr/lib/libgcc.a(comparedf2.o): In
> > function `__gtdf2':
> > /usr/src/contrib/compiler-rt/lib/builtins/comparedf2.c:141: multiple
> > definition of `__gtdf2'
> > /usr/obj/usr/src/mips.mips64/tmp/usr/lib/libc.a(gtdf2.o):/
> > usr/src/lib/libc/softfloat/gtdf2.c:18: first defined here
> >
> > undefined.... devd doesn't even use strtodl.
> >
> > (looks like the code to associate make output with the right commands is
> > broken, since I had to dig for it.
> >
> > Warner
> >
> >
> >> Steve
> >>
> >>
> >> On 01/30/2018 22:05, Warner Losh wrote:
> >>
> >>> Author: imp
> >>> Date: Wed Jan 31 03:05:14 2018
> >>> New Revision: 328612
> >>> URL: https://svnweb.freebsd.org/changeset/base/328612
> >>>
> >>> Log:
> >>>    Move strtold wrapper from strtol.c to its own strtold.c.  This code
> >>>    was written by theraven@ (David Chisnall) entirely, there's no
> >>>    original Berkeley code left here so just copy his copyright over.
> >>>
> >>>
> >


-- 
John Baldwin