svn commit: r329886 - head/sys/vm

Mark Johnston markj at FreeBSD.org
Fri Feb 23 23:27:54 UTC 2018


Author: markj
Date: Fri Feb 23 23:27:53 2018
New Revision: 329886
URL: https://svnweb.freebsd.org/changeset/base/329886

Log:
  Correct some comments after r328954.
  
  Reviewed by:	kib
  Differential Revision:	https://reviews.freebsd.org/D14486

Modified:
  head/sys/vm/vm_reserv.c

Modified: head/sys/vm/vm_reserv.c
==============================================================================
--- head/sys/vm/vm_reserv.c	Fri Feb 23 23:25:22 2018	(r329885)
+++ head/sys/vm/vm_reserv.c	Fri Feb 23 23:27:53 2018	(r329886)
@@ -511,19 +511,14 @@ vm_reserv_populate(vm_reserv_t rv, int index)
 }
 
 /*
- * Allocates a contiguous set of physical pages of the given size "npages"
- * from existing or newly created reservations.  All of the physical pages
- * must be at or above the given physical address "low" and below the given
- * physical address "high".  The given value "alignment" determines the
- * alignment of the first physical page in the set.  If the given value
- * "boundary" is non-zero, then the set of physical pages cannot cross any
- * physical address boundary that is a multiple of that value.  Both
- * "alignment" and "boundary" must be a power of two.
+ * Attempts to allocate a contiguous set of physical pages from existing
+ * reservations.  See vm_reserv_alloc_contig() for a description of the
+ * function's parameters.
  *
  * The page "mpred" must immediately precede the offset "pindex" within the
  * specified object.
  *
- * The object and free page queue must be locked.
+ * The object must be locked.
  */
 vm_page_t
 vm_reserv_extend_contig(int req, vm_object_t object, vm_pindex_t pindex,
@@ -606,7 +601,7 @@ out:
 
 /*
  * Allocates a contiguous set of physical pages of the given size "npages"
- * from existing or newly created reservations.  All of the physical pages
+ * from newly created reservations.  All of the physical pages
  * must be at or above the given physical address "low" and below the given
  * physical address "high".  The given value "alignment" determines the
  * alignment of the first physical page in the set.  If the given value
@@ -614,6 +609,9 @@ out:
  * physical address boundary that is a multiple of that value.  Both
  * "alignment" and "boundary" must be a power of two.
  *
+ * Callers should first invoke vm_reserv_extend_contig() to attempt an
+ * allocation from existing reservations.
+ *
  * The page "mpred" must immediately precede the offset "pindex" within the
  * specified object.
  *
@@ -836,7 +834,9 @@ vm_reserv_extend(int req, vm_object_t object, vm_pinde
 }
 
 /*
- * Allocates a page from an existing reservation.
+ * Attempts to allocate a new reservation for the object, and allocates a
+ * page from that reservation.  Callers should first invoke vm_reserv_extend()
+ * to attempt an allocation from an existing reservation.
  *
  * The page "mpred" must immediately precede the offset "pindex" within the
  * specified object.


More information about the svn-src-head mailing list