svn commit: r329866 - head/sys/cam

Ian Lepore ian at freebsd.org
Fri Feb 23 20:25:00 UTC 2018


On Fri, 2018-02-23 at 16:06 +0000, Warner Losh wrote:
> -static inline int
> +static inline bool
>  cam_iosched_has_flagged_work(struct cam_iosched_softc *isc)
>  {
>         return !!(isc->flags & CAM_IOSCHED_FLAG_WORK_FLAGS);
>  }

There should be no need for the ugly !! here, conversion to bool in C99
is like it is for c++, it converts to zero if the expression being
converted has a value of zero, or to one otherwise.

-- Ian


More information about the svn-src-head mailing list