svn commit: r329853 - in head: lib/libifconfig share/examples/libifconfig usr.sbin/wlandebug

[Alan Somers]

On Fri, Feb 23, 2018 at 7:47 AM, Rodney W. Grimes <
freebsd at pdx.rh.cn85.dnsmgr.net> wrote:

> > Author: asomers
> > Date: Fri Feb 23 03:11:43 2018
> > New Revision: 329853
> > URL: https://svnweb.freebsd.org/changeset/base/329853
> >
> > Log:
> >   libifconfig: multiple feature additions
> >
> >   Added the ability to:
> >
> >   * Create virtual interfaces
> >   * Create vlan interfaces
> >   * Get interface fib
> >   * Get interface groups
> >   * Get interface status
> >   * Get nd6 info
> >   * Get media status
> >   * Get additional ifaddr info in a convenient struct
> >   * Get vhids
> >   * Get carp info
> >   * Get lagg and laggport status
> >   * Iterate over all interfaces and ifaddrs
>
> Love that list!!!
> >
> >   And add more examples, too.
>
> Remove MIT 1996 Copyright?
> Under what conditions is it that this is being done?
>

The file's original author removed the extra license block.  It probably
shouldn't have been there to begin with.
https://github.com/Savagedlight/libifconfig/commit/92fa671bd2451c11c9f1abf68b56295a05af2c85#diff-d2b1298dd60d9c72a5776c8d57a7fe78


> >   Note that this is a backwards-incompatible change. But that's ok,
> because it's
> >   a private library.
> >
> >   MFC after:  3 weeks
> >   Sponsored by:       Spectra Logic Corp
> >   Differential Revision:      https://reviews.freebsd.org/D14463
>
> With 0 feed back?  And a ~30 hour life time?  It is not a diffential if
> no one looks at, comments on, or accepts the revision.
>
>
Actually, it's been under review for nearly nine months, but on Github, not
Phabricator.  You see, the original author lacks a commit bit, and has
developed this library out-of-tree.  It's time we brought it back in,
though.  I know the Phabricator review didn't last very long, but I have a
time limitation on my end.  Feel free to tear it apart in post-commit
review, if you like.

https://github.com/Savagedlight/libifconfig/pull/46

-Alan