svn commit: r329824 - in head: sbin/nvmecontrol sys/cam/nvme sys/conf sys/dev/mpr sys/dev/nvme

[Warner Losh]

On Thu, Feb 22, 2018 at 9:20 AM, Kyle Evans <kevans at freebsd.org> wrote:

> On Thu, Feb 22, 2018 at 10:19 AM, Alan Somers <asomers at freebsd.org> wrote:
> > On Thu, Feb 22, 2018 at 6:32 AM, Wojciech Macek <wma at freebsd.org> wrote:
> >
> >> Author: wma
> >> Date: Thu Feb 22 13:32:31 2018
> >> New Revision: 329824
> >> URL: https://svnweb.freebsd.org/changeset/base/329824
> >>
> >> Log:
> >>   NVMe: Add big-endian support
> >>
> >>   Remove bitfields from defined structures as they are not portable.
> >>   Instead use shift and mask macros in the driver and nvmecontrol
> >> application.
> >>
> >>   NVMe is now working on powerpc64 host.
> >>
> >>   Submitted by:          Michal Stanek <mst at semihalf.com>
> >>   Obtained from:         Semihalf
> >>   Reviewed by:           imp, wma
> >>   Sponsored by:          IBM, QCM Technologies
> >>   Differential revision: https://reviews.freebsd.org/D13916
> >>
> >
> > It looks like this change broke the build with Clang:
> >
>
> Fixed in r329827... all little endian arch's broken, not so great. =(
>

At least the kernel is passing my tests this morning... I didn't think this
was ready and hasn't yet lifted my objections in the review... Not sure I
want to get grumpy about it yet, but I'm not pleased to see this.

Warner