svn commit: r329458 - head/sbin/devmatch

[Warner Losh]

On Sat, Feb 17, 2018 at 7:58 AM, Hans Petter Selasky <hps at selasky.org>
wrote:

> On 02/17/18 15:56, Warner Losh wrote:
>
>> I'd request you make no further changes to devmatch without a review.
>>
>
> I don't have a problem with that.
>
> You can see now what changes are needed. Please make sure you test with
> real USB devices! Some people are using FreeBSD-current on desktops, and
> the USB auto-load feature has been broken for almost a week now.


(a) It's current (b) It took longer to sort out than I'd hoped (c) I tested
with a keyboard and mouse on my main server. It was absolutely tested.
Snide comments like this aren't helping my already grumpy mood over this.

It would be more helpful if you could turn on devd's logging (by adding
!devd
*.>=info                                       /var/log/devd.log
to /etc/syslog.conf, restarting syslog and then giving me the exact
scenario that's failing so I can add it to a test suite I'm writing. The
data will be in /var/log/devd.log. I can't possibly test all the crazy USB
scenarios with the hardware I have (there's too many of them), but I can
test it in simulation and make sure we're good.

The multiple driver matching thing was never ever mentioned in prior
things, so getting snippy with me over it for not testing it is not
helpful. Understanding what to look for will be helpful in making sure the
test suites catch it and we fix the underlying issues.

Warner