svn commit: r329296 - head/sbin/devd

[Eitan Adler]

On 14 February 2018 at 19:48, Warner Losh <imp at bsdimp.com> wrote:
>
>
> On Wed, Feb 14, 2018 at 8:39 PM, Warner Losh <imp at bsdimp.com> wrote:
>>
>>
>>
>> On Feb 14, 2018 8:23 PM, "Eitan Adler" <eadler at freebsd.org> wrote:
>>
>> Author: eadler
>> Date: Thu Feb 15 03:22:53 2018
>> New Revision: 329296
>> URL: https://svnweb.freebsd.org/changeset/base/329296
>>
>> Log:
>>   devd: don't pass &fds in useless parameters to select(2)
>>
>>   select(2) should be declared as restrict. In addition the only fd in
>>   the fdset is open O_RDONLY, and it's not a socket that can provide OOB
>>   notifications,
>>
>>   Reviewed by:  ian, imp, vangyzen
>>
>>
>> Don't put my name on this. I specifically and clearly objected to the
>> change anf tld yoy not to do it.
>
>
> Stupid phone...
>
> I specifically objected to this change. I said not to make it because it
> wasn't necessary. You did it any way. Don't put "reviewed by" for that. Put
> "objected to but I did it anyway by: imp"

hrm.. rereading the thread I think I missed your original email. Only
comment I saw was "poll is a better interface". Sorry for mis-stating
your opinion.

FTR I'd like to fix the declaration of select(2) anyways.

-- 
Eitan Adler
Source, Ports, Doc committer
Bugmeister, Ports Security teams