svn commit: r329237 - head/sys/libkern

[Eric van Gyzen]

On 02/13/2018 13:43, Ed Maste wrote:
> On 13 February 2018 at 14:23, Ian Lepore <ian at freebsd.org> wrote:
>> On Tue, 2018-02-13 at 19:17 +0000, Ed Maste wrote:
>>> Author: emaste
>>> Date: Tue Feb 13 19:17:48 2018
>>> New Revision: 329237
>>> URL: https://svnweb.freebsd.org/changeset/base/329237
>>>
>>> Log:
>>>   libkern: use nul for terminating char rather than 0
>>>
>>>   Akin to the change made in r188080 for lib/libc/string/.
>>>
>>>   Reported by:        bde
>>>   Sponsored by:       The FreeBSD Foundation
>>
>> There are many ways to spell 0.  Why are we using something other than
>> the simplest way?  Is it a style rule thing, or is it portability-
>> correctness, or what?
> 
> I made the change to improve consistency between lib/libc/string and
> sys/libkern, which is what Bruce commented on some time ago. I don't
> have a personal preference for 0 or '\0' but definitely believe that
> if we have multiple, similar copies of a function they ought to avoid
> gratuitous differences. (I'm happy to change both trees to 0 if that's
> preferred.)

I prefer '\0' here because it tells the reader that it's a NUL
character, as opposed to a NULL pointer or a zero integer.  Yes, the
reader should already know that, but the author can /help/ the reader by
communicating more clearly and completely.

Eric