svn commit: r341446 - head/release/amd64

[Alexey Dokuchaev]

On Tue, Dec 04, 2018 at 11:52:34AM +0300, Yuri Pankov wrote:
> Alexey Dokuchaev wrote:
> > On Mon, Dec 03, 2018 at 10:31:57PM +0000, Yuri Pankov wrote:
> >> New Revision: 341446
> >> URL: https://svnweb.freebsd.org/changeset/base/341446
> >>
> >> Log:
> >>   mkisoimages.sh: don't use -p flag when copying loader.efi to msdosfs.
> >>   
> >>   This fixes 'cdrom' target in the case when world was built by user,
> >>   and not root.
> > 
> > Could you please explain why -p should not have been used here?  I fail
> > to understand this from the commit log.  I've always considered preserving
> > various file metadata as a good thing to do, and this commit puzzles me.
> 
> Because the target is on msdosfs, and the only metadata that can be
> preserved is modification time which isn't that useful with the file
> being hidden in ESP.  OTOH, 'cp -p' fails trying to preserve owner/group
> if source is not owned by root (as commit message says).  Additional
> 'chmod' call done in HBSD doesn't do much as well -- it seems we can
> only set/unset owner's 'write' flag which corresponds to DOS 'readonly'
> attribute.

Ah, I see now, so cp(1) was failing and that upset 'set -e'.  Thanks for
explanation.

./danfe